Fix extreme time trying to load favicon data

[BPerlakiH]

Related to: #1352

There's a clear regression issue in libkiwix 14.1.

Context

We have this call:

book->getIllustrations().at(0)->getData();

It suppose to return the favicons image data. We are calling it as part of fetching the catalog. In reality, it never returns any data, but that's nothing new, it wasn't returning any data as of libkiwix 14.0.1 either.
(see related past issues: kiwix/libkiwix#1180, I am not sure if that was meant to be fixed)

The problem

The real problem is how long it tries to do return that data (even-though the result is always nil).
I've checked the commit merging libkiwix 14.1, and the one right before, and compared the builds from both by running fresh installs on iPad.
On libkiwix 14.0.1 the average time to fetch the catalog is about 20 sec.
On libkiwix 14.1, I got fed up measuring it when it went over 1 minute 30 sec (and still not finished doing it).

Solution

If we bypass this call, and return directly nil, the outcome will be the same, but we don't need to wait for it, and we get back to our expected ~20 seconds loading time.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.54%. Comparing base (4fc33a3) to head (f2b52b9).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1359   +/-   ##
=======================================
  Coverage   92.54%   92.54%           
=======================================
  Files          17       17           
  Lines         872      872           
=======================================
  Hits          807      807           
  Misses         65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[kelson42]

@BPerlakiH Open an issue at libkiwix if you think libkiwix has a bug

[BPerlakiH]

@BPerlakiH Open an issue at libkiwix if you think libkiwix has a bug

kiwix/libkiwix#1242