Skip to content

Conversation

@BPerlakiH
Copy link
Collaborator

Solving the first points from #1391:

  • The overall feature is an "ZIM file integrity check", not a "validation". The code vocabulary should be changed
  • The button label should be changed from "Validate" to "Check ZIM archive integrity"
  • The result entry should not be mixed with the multimedia content details but put just above the button, together in a section. The label should be changed from "valid" to "ZIM archive integrity".

iPad

Simulator Screenshot - iPad Air 13-inch (iOS 26) - 2025-12-03 at 00 53 10 Simulator Screenshot - iPad Air 13-inch (iOS 26) - 2025-12-03 at 00 53 01 Simulator Screenshot - iPad Air 13-inch (iOS 26) - 2025-12-03 at 00 52 52

macOS

Screenshot 2025-12-03 at 00 46 36 Screenshot 2025-12-03 at 00 46 26 Screenshot 2025-12-03 at 00 46 15

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.59%. Comparing base (ceb4828) to head (a1b5340).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1394   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files          18       18           
  Lines         878      878           
=======================================
  Hits          813      813           
  Misses         65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BPerlakiH BPerlakiH force-pushed the 1391-integrity-check-improvements branch from 634fb74 to e8d7627 Compare December 5, 2025 22:44
@kelson42 kelson42 force-pushed the 1391-integrity-check-improvements branch from e8d7627 to 76f8290 Compare December 6, 2025 14:05
Copy link
Contributor

@kelson42 kelson42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • * On iPad, the look & feel of screenshot #3 is good and should be kept during the check itself. Which means, also keeping the "Cancel" putting to interrupt the test.
  • * "Checking ZIM file..." dialog title seems to me to be a bit redundant with the button "Check ZIM archive integrity". I wonder if we would not better just get rid of it.
  • * I would like to merge the two about "Check ZIM archive integrity". We would get only one line/entry with the following items from the left to the right (LTR language): label "ZIM archive integrity", then in the middle a button "Check/Re-check" and at the right the icon.
  • * If you write the title of a book, please put it between double quote

@BPerlakiH
Copy link
Collaborator Author

Simulator Screenshot - iPad Air 13-inch (iOS 26) - 2025-12-13 at 11 06 12 Medium Simulator Screenshot - iPad Air 13-inch (iOS 26) - 2025-12-13 at 11 06 15 Medium Simulator Screenshot - iPad Air 13-inch (iOS 26) - 2025-12-13 at 11 06 08 Medium

@BPerlakiH BPerlakiH force-pushed the 1391-integrity-check-improvements branch from cebd921 to a1b5340 Compare December 13, 2025 10:09
@BPerlakiH BPerlakiH requested a review from kelson42 December 13, 2025 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants