-
-
Notifications
You must be signed in to change notification settings - Fork 89
Improve check integrity naming and look #1394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BPerlakiH
wants to merge
9
commits into
main
Choose a base branch
from
1391-integrity-check-improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdb6021 to
634fb74
Compare
10 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1394 +/- ##
=======================================
Coverage 92.59% 92.59%
=======================================
Files 18 18
Lines 878 878
=======================================
Hits 813 813
Misses 65 65 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
634fb74 to
e8d7627
Compare
e8d7627 to
76f8290
Compare
kelson42
reviewed
Dec 6, 2025
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- * On iPad, the look & feel of screenshot #3 is good and should be kept during the check itself. Which means, also keeping the "Cancel" putting to interrupt the test.
- * "Checking ZIM file..." dialog title seems to me to be a bit redundant with the button "Check ZIM archive integrity". I wonder if we would not better just get rid of it.
- * I would like to merge the two about "Check ZIM archive integrity". We would get only one line/entry with the following items from the left to the right (LTR language): label "ZIM archive integrity", then in the middle a button "Check/Re-check" and at the right the icon.
- * If you write the title of a book, please put it between double quote
dad4250 to
d3222e5
Compare
74f515a to
c38fcda
Compare
Collaborator
Author
cebd921 to
a1b5340
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Solving the first points from #1391:
iPad
macOS