Conversation
* Run go fix * Upgrade goreleaser * Use fixed fuzztime
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughBumps Go toolchain and GoReleaser versions in CI and release workflows, updates module Go versions, modernizes or removes legacy build-tag lines (with a few files changing build-logic), and makes small test/code adjustments (FieldsSeq, CutSuffix, slices.Contains, deterministic RNG, and a loop-variable change that may reintroduce closure capture). Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/go.yml (1)
100-103: Replace deprecatedgit.ioredirect with direct GitHub URL.The
git.io/goreleasershortener is deprecated and in read-only mode since 2022. While it currently redirects tohttps://raw.githubusercontent.com/goreleaser/get/master/getand works, relying on a deprecated redirect service introduces unnecessary fragility.Replace both instances with the direct GitHub URL:
https://raw.githubusercontent.com/goreleaser/get/master/getLines 100 and 103 examples:
run: curl -sfL https://raw.githubusercontent.com/goreleaser/get/master/get | VERSION=v2.13.3 sh -s -- check - name: goreleaser snapshot run: curl -sL https://raw.githubusercontent.com/goreleaser/get/master/get | VERSION=v2.13.3 sh -s -- --snapshot --clean🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/go.yml around lines 100 - 103, Replace the deprecated git.io shortener usage in the two workflow steps that invoke goreleaser (the lines running curl for the check and the goreleaser snapshot step) by using the direct raw GitHub URL (raw.githubusercontent.com/goreleaser/get/master/get) instead of https://git.io/goreleaser; update both occurrences (the check invocation and the snapshot --snapshot --clean invocation) to curl the direct GitHub URL while keeping the existing VERSION=v2.13.3 and sh -s -- arguments unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/go.yml:
- Around line 100-103: Replace the deprecated git.io shortener usage in the two
workflow steps that invoke goreleaser (the lines running curl for the check and
the goreleaser snapshot step) by using the direct raw GitHub URL
(raw.githubusercontent.com/goreleaser/get/master/get) instead of
https://git.io/goreleaser; update both occurrences (the check invocation and the
snapshot --snapshot --clean invocation) to curl the direct GitHub URL while
keeping the existing VERSION=v2.13.3 and sh -s -- arguments unchanged.
go mod tidy
Owner
Author
|
hmmm.. Seeing golang/go#75804 - maybe revert until there is a fix? |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/go.yml:
- Around line 100-103: Update both curl invocations that fetch goreleaser to use
the official installer URL and consistent curl flags: replace the deprecated
short URL "https://git.io/goreleaser" with "https://goreleaser.com/static/run"
in both runs and make the second run use the same "-sfL" flags as the first (so
both lines use curl -sfL https://goreleaser.com/static/run ...), preserving the
VERSION=v2.13.3 and the existing arguments (-- check and -- --snapshot --clean)
and keeping the "goreleaser snapshot" step name intact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Chores
Refactor