Skip to content

feat: omit empty logical operators (AND, OR, NOT) from query#26

Merged
mithleshjs merged 1 commit intomainfrom
25-empty-logical-operators-and-or-not-in-query
Mar 18, 2025
Merged

feat: omit empty logical operators (AND, OR, NOT) from query#26
mithleshjs merged 1 commit intomainfrom
25-empty-logical-operators-and-or-not-in-query

Conversation

@mithleshjs
Copy link
Member

  • Updated query builder logic to filter out invalid or missing conditions for AND, OR, and NOT operators.
  • Logical operators are now only included in the query if their corresponding conditions array is non-empty.
  • Returns an empty query or default query if no valid conditions are present for any logical operator.
  • Prevents incorrect query structures like { AND: [], OR: [], NOT: [] } from being generated.

@mithleshjs mithleshjs linked an issue Mar 18, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.86%. Comparing base (1cc2fc2) to head (0bc38a4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage   99.85%   99.86%           
=======================================
  Files          14       14           
  Lines         711      717    +6     
=======================================
+ Hits          710      716    +6     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mithleshjs mithleshjs merged commit c5e44b0 into main Mar 18, 2025
4 checks passed
@mithleshjs mithleshjs deleted the 25-empty-logical-operators-and-or-not-in-query branch March 18, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Empty Logical Operators (AND, OR, NOT) in Query

1 participant