-
Notifications
You must be signed in to change notification settings - Fork 624
Open
Labels
good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.triage/acceptedIssues which should be fixed (post-triage)Issues which should be fixed (post-triage)
Description
We have the same function public in cmd/broker:
Lines 30 to 38 in e804605
| func GetLoggingConfig(ctx context.Context, namespace, loggingConfigMapName string) (*logging.Config, error) { | |
| loggingConfigMap, err := kubeclient.Get(ctx).CoreV1().ConfigMaps(namespace).Get(ctx, loggingConfigMapName, metav1.GetOptions{}) | |
| if apierrors.IsNotFound(err) { | |
| return logging.NewConfigFromMap(nil) | |
| } else if err != nil { | |
| return nil, err | |
| } | |
| return logging.NewConfigFromConfigMap(loggingConfigMap) | |
| } |
Originally posted by @creydr in #8699 (comment)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.triage/acceptedIssues which should be fixed (post-triage)Issues which should be fixed (post-triage)
Type
Projects
Status
Backlog