Add tracing for TestBrokerWithManyTriggers by pierDipi · Pull Request #7077 · knative/eventing

pierDipi · 2023-07-04T15:34:27Z

For debugging flaky tests.

As described here: https://github.com/knative-sandbox/reconciler-test#inspecting-zipkin-traces-for-failed-tests

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

pierDipi · 2023-07-04T15:34:38Z

/cc @creydr @Cali0707

Cali0707 · 2023-07-04T15:39:11Z

/lgtm

Cali0707 · 2023-07-04T15:39:58Z

/test unit-tests

Cali0707 · 2023-07-04T15:52:23Z

/retest-required

pierDipi · 2023-07-04T15:58:49Z

/test unit-tests

creydr

/lgtm

creydr · 2023-07-04T16:05:19Z

/retest

Cali0707 · 2023-07-04T16:34:39Z

/test reconciler-tests

Cali0707 · 2023-07-04T18:23:01Z

/test reconciler-tests

Cali0707 · 2023-07-04T19:24:48Z

@pierDipi it's the tests that this PR is supposed to help debug that are failing on this PR. Any ideas what to do?

pierDipi · 2023-07-05T07:45:14Z

in https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_eventing/7077/reconciler-tests_eventing_main/1676295572631326720

TestBrokerWithManyTriggers/broker_With_Many_Triggers/Assert/test_message_without_explicit_prefer_header_should_have_the_header_delivers_events#35

For dumper-12 assertion, we get

        - Match errors -
        0 - expecting attribute 'id' equal to '9187ff8c-b2b3-4664-9231-7a7eeaba253f', got 'dcb1f640-f055-4023-86ec-a8271af6b4a3'
        1 - expecting attribute 'id' equal to '9187ff8c-b2b3-4664-9231-7a7eeaba253f', got 'b2d28d34-f88e-4c21-9ab2-b710e62be731'
        2 - expecting attribute 'id' equal to '9187ff8c-b2b3-4664-9231-7a7eeaba253f', got '761a313c-e0cd-4614-948b-92da96833121'
        3 - expecting attribute 'id' equal to '9187ff8c-b2b3-4664-9231-7a7eeaba253f', got '6589d88c-2ec9-4fbc-94e1-2623c8f0aa1d'
        4 - expecting attribute 'id' equal to '9187ff8c-b2b3-4664-9231-7a7eeaba253f', got '6f47811a-fd12-4e89-9798-b8f1c3ea0b8e'
        5 - expecting attribute 'id' equal to '9187ff8c-b2b3-4664-9231-7a7eeaba253f', got 'ce0e2be1-3ae9-4b46-a6f2-3f2831560bd4'

This is the event with such id:

Context Attributes
specversion: 1.0
type: type2
source: http://source2.com
id: 9187ff8c-b2b3-4664-9231-7a7eeaba253f
datacontenttype: application/json

Extensions
extname1: extval1
extname2: extvalue2

Data (binary)

{ "msg": "3eb9045b-af05-4b4c-8458-0eb6995066d9" }

However, dumper-12 filters events with:

type: type1 and "any" source`:

eventing/test/rekt/features/broker/feature.go

Line 70 in f5b1b12

eventFilters1["dumper-12"] = neweventTestCase(eventType1, any)

eventing/test/rekt/features/broker/feature.go

Lines 1012 to 1014 in f5b1b12

    
           func neweventTestCase(tp, source string) eventTestCase { 
        
           	return eventTestCase{Type: tp, Source: source} 
        
           }

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

codecov · 2023-07-05T08:50:42Z

Codecov Report

Patch coverage: 58.76% and project coverage change: -0.17 ⚠️

Comparison is base (cb2a891) 78.75% compared to head (a6498b6) 78.59%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7077      +/-   ##
==========================================
- Coverage   78.75%   78.59%   -0.17%     
==========================================
  Files         248      249       +1     
  Lines       13148    13228      +80     
==========================================
+ Hits        10355    10396      +41     
- Misses       2273     2304      +31     
- Partials      520      528       +8

Impacted Files	Coverage Δ
pkg/adapter/mtping/runner.go	`80.48% <0.00%> (ø)`
pkg/channel/message_dispatcher.go	`73.17% <0.00%> (-1.83%)`	⬇️
pkg/reconciler/source/duck/duck.go	`74.68% <0.00%> (-2.05%)`	⬇️
pkg/resolver/kresource_resolver.go	`0.00% <ø> (ø)`
pkg/broker/ingress/ingress_handler.go	`70.23% <11.11%> (-7.10%)`	⬇️
pkg/broker/ttl.go	`71.42% <66.66%> (ø)`
pkg/broker/eventtypes.go	`72.22% <72.22%> (ø)`
pkg/adapter/v2/cloudevents.go	`78.06% <100.00%> (+0.11%)`	⬆️
pkg/apis/eventing/v1beta2/eventtype_defaults.go	`100.00% <100.00%> (ø)`
pkg/broker/filter/filter_handler.go	`71.19% <100.00%> (+0.07%)`	⬆️
... and 1 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

pierDipi · 2023-07-05T12:05:25Z

/test upgrade-tests

Cali0707

/lgtm

Cali0707 · 2023-07-05T12:43:59Z

/test upgrade-tests

creydr

/lgtm

knative-prow · 2023-07-05T12:44:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [creydr,pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

For debugging [flaky tests](https://github.com/knative/eventing/issues?q=is%3Aissue+is%3Aopen+label%3Aauto%3Aflaky). As described here: https://github.com/knative-sandbox/reconciler-test#inspecting-zipkin-traces-for-failed-tests --------- Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Add tracing for TestBrokerWithManyTriggers

e698753

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 4, 2023

knative-prow bot requested review from Cali0707 and creydr July 4, 2023 15:34

knative-prow bot added the area/test-and-release Test infrastructure, tests or release label Jul 4, 2023

knative-prow bot requested review from evankanderson and odacremolbap July 4, 2023 15:34

knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2023

knative-prow bot assigned Cali0707 Jul 4, 2023

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2023

Cali0707 approved these changes Jul 4, 2023

View reviewed changes

creydr approved these changes Jul 4, 2023

View reviewed changes

knative-prow bot assigned creydr Jul 4, 2023

Refactor test

7bcbfb0

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 5, 2023

Improve test names

e282312

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

pierDipi force-pushed the tracing-broker-with-many-triggers branch from e77fb8c to e282312 Compare July 5, 2023 08:45

pierDipi changed the title ~~Add tracing for TestBrokerWithManyTriggers~~ [WIP] Add tracing for TestBrokerWithManyTriggers Jul 5, 2023

knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2023

pierDipi force-pushed the tracing-broker-with-many-triggers branch from a16796f to c8e6855 Compare July 5, 2023 10:45

knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 5, 2023

Maybe it's a data race bug

a6498b6

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

pierDipi force-pushed the tracing-broker-with-many-triggers branch from c8e6855 to a6498b6 Compare July 5, 2023 10:50

knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 5, 2023

pierDipi changed the title ~~[WIP] Add tracing for TestBrokerWithManyTriggers~~ Add tracing for TestBrokerWithManyTriggers Jul 5, 2023

knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2023

pierDipi requested review from Cali0707 and creydr July 5, 2023 12:05

Cali0707 approved these changes Jul 5, 2023

View reviewed changes

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2023

creydr approved these changes Jul 5, 2023

View reviewed changes

knative-prow bot merged commit eaf28a7 into knative:main Jul 5, 2023

pierDipi deleted the tracing-broker-with-many-triggers branch July 5, 2023 13:05

Conversation

pierDipi commented Jul 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pierDipi commented Jul 4, 2023

Uh oh!

Cali0707 commented Jul 4, 2023

Uh oh!

Cali0707 commented Jul 4, 2023

Uh oh!

Cali0707 commented Jul 4, 2023

Uh oh!

pierDipi commented Jul 4, 2023

Uh oh!

creydr left a comment

Choose a reason for hiding this comment

Uh oh!

creydr commented Jul 4, 2023

Uh oh!

Cali0707 commented Jul 4, 2023

Uh oh!

Cali0707 commented Jul 4, 2023

Uh oh!

Cali0707 commented Jul 4, 2023

Uh oh!

pierDipi commented Jul 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jul 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pierDipi commented Jul 5, 2023

Uh oh!

Cali0707 left a comment

Choose a reason for hiding this comment

Uh oh!

Cali0707 commented Jul 5, 2023

Uh oh!

creydr left a comment

Choose a reason for hiding this comment

Uh oh!

knative-prow bot commented Jul 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pierDipi commented Jul 4, 2023 •

edited

Loading

pierDipi commented Jul 5, 2023 •

edited

Loading

codecov bot commented Jul 5, 2023 •

edited

Loading