Move ingress & filter TLS secret names into constants

[creydr]

Follow up on #6986 (comment):

Moved the tls secret names for mt-broker-ingress & mt-broker-filter into constants

[creydr]

/assign @pierDipi

[codecov]

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.01 ⚠️

Comparison is base (1e96c78) 78.31% compared to head (377be6a) 78.31%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7081      +/-   ##
==========================================
- Coverage   78.31%   78.31%   -0.01%     
==========================================
  Files         250      250              
  Lines       13291    13290       -1     
==========================================
- Hits        10409    10408       -1     
  Misses       2351     2351              
  Partials      531      531              

Impacted Files	Coverage Δ
pkg/broker/filter/server_manager.go	0.00% <0.00%> (ø)
pkg/broker/ingress/server_manager.go	0.00% <0.00%> (ø)
pkg/reconciler/broker/broker.go	77.27% <33.33%> (-0.08%)	⬇️
pkg/reconciler/broker/trigger/trigger.go	82.71% <33.33%> (ø)
pkg/reconciler/broker/controller.go	87.83% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[pierDipi]

This import has the side effect of starting a whole bunch of informers

[creydr]

ahh. So better keeping it in the pkg/broker|filter package then I guess

[pierDipi]

Doesn't that have the same side effect?

For example, broker/filter package might need an informer that the controller doesn't need which would waste resources or require additional permissions (like Eventype informer is not needed on the controller but needed on the broker ingress)

[pierDipi]

Even if it's not needed or it works fine right now, it seems we're creating code coupling that is not really necessary and might break in the future, the secret name can be considered a contract (which it is even today) because changing the secret name is not as simple as changing the constant (we need at least to change the cert manager resources but also migration, etc would be necessary)

[pierDipi]

Thanks!

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [creydr,pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment