Skip to content

Guard reserved access with lock and create vpods in tests#8457

Merged
knative-prow[bot] merged 2 commits intoknative:mainfrom
pierDipi:guard-test-reserved-access-lock
Feb 25, 2025
Merged

Guard reserved access with lock and create vpods in tests#8457
knative-prow[bot] merged 2 commits intoknative:mainfrom
pierDipi:guard-test-reserved-access-lock

Conversation

@pierDipi
Copy link
Member

@pierDipi pierDipi commented Feb 12, 2025

Fix data race in tests

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 12, 2025
@knative-prow knative-prow bot requested review from aliok and matzew February 12, 2025 11:19
@codecov
Copy link

codecov bot commented Feb 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.80%. Comparing base (5bcee30) to head (d355ccf).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8457      +/-   ##
==========================================
- Coverage   62.83%   62.80%   -0.03%     
==========================================
  Files         396      396              
  Lines       24233    24233              
==========================================
- Hits        15226    15220       -6     
- Misses       8199     8203       +4     
- Partials      808      810       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

matzew
matzew approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2025
@knative-prow
Copy link

knative-prow bot commented Feb 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member Author

pierDipi commented Feb 12, 2025

/test unit-tests

1 similar comment
@matzew
Copy link
Member

matzew commented Feb 12, 2025

/test unit-tests

@matzew
Copy link
Member

matzew commented Feb 12, 2025

there seems to be a test issue

@pierDipi
Guard reserved access with lock in tests
50158bc
@pierDipi
Create vpods in test
d355ccf 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi pierDipi force-pushed the guard-test-reserved-access-lock branch from c4206df to d355ccf Compare February 25, 2025 07:54
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 25, 2025
@pierDipi pierDipi changed the title Guard reserved access with lock in tests Guard reserved access with lock and create vpods in tests Feb 25, 2025
@pierDipi
Copy link
Member Author

pierDipi commented Feb 25, 2025

/cherry-pick release-1.17

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Feb 25, 2025

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.17 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pierDipi pierDipi requested a review from matzew February 25, 2025 08:57
@matzew
Copy link
Member

matzew commented Feb 25, 2025

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2025
@knative-prow knative-prow bot merged commit 80dd84e into knative:main Feb 25, 2025
30 of 36 checks passed
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Feb 25, 2025

@pierDipi: new pull request created: #8504

Details

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Feb 25, 2025
Merged
@pierDipi
Copy link
Member Author

pierDipi commented Feb 25, 2025

/cherry-pick release-1.16

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Feb 25, 2025

@pierDipi: new pull request created: #8505

Details

In response to this:

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Feb 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aliok aliok Awaiting requested review from aliok

@matzew matzew Awaiting requested review from matzew

Assignees

@matzew matzew

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pierDipi @matzew @knative-prow-robot