Skip to content

[release-1.18] Fix MT Channel based broker when OIDC is enabled#8778

Merged
knative-prow[bot] merged 2 commits intoknative:release-1.18from
twoGiants:cherry-pick-8727-into-release-1.18
Oct 31, 2025
Merged

[release-1.18] Fix MT Channel based broker when OIDC is enabled#8778
knative-prow[bot] merged 2 commits intoknative:release-1.18from
twoGiants:cherry-pick-8727-into-release-1.18

Conversation

@twoGiants
Copy link
Contributor

@twoGiants twoGiants commented Oct 24, 2025 •
edited
Loading

This is a manual cherry-pick of #8727

Fixes broken MT channel based broker when TLS is disabled and OIDC enabled

@twoGiants
Fix MT Channel based broker when OIDC is enabled
b51e574 
fix: extract channel service suffix into constant

When OIDC is enabled and https is disabled (i.e. http requests are used)
the event receiver is using the host name to determine the name of the
channel and fails to do so. An example host name is
`broker-kne-trigger-kn-channel.namespace-1.svc.cluster.local`. The
channel name here is `broker-kne-trigger` without the suffix
`-kn-channel` which was hardcoded in the logic which was creating the
channel owned k8 service.

The constant `-kn-channel` is now extracted into a common constant in
the `channel` package. A conditional check in `ParseChannelFromHost` now
checks for the suffix in the host name and removes it if needed.
An additional test case was added and existing tests were updated.

Issue knative#8705.

Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com>
@knative-prow knative-prow bot added the area/test-and-release Test infrastructure, tests or release label Oct 24, 2025
@knative-prow knative-prow bot requested review from aliok and mgencur October 24, 2025 15:00
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 24, 2025
@codecov
Copy link

codecov bot commented Oct 24, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.86%. Comparing base (d499be4) to head (601a9e5).
⚠️ Report is 1 commits behind head on release-1.18.

Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.18    #8778      +/-   ##
================================================
+ Coverage         52.35%   52.86%   +0.50%     
================================================
  Files               397      397              
  Lines             24937    19977    -4960     
================================================
- Hits              13056    10560    -2496     
+ Misses            11090     8626    -2464     
  Partials            791      791

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@twoGiants
Copy link
Contributor Author

twoGiants commented Oct 28, 2025

/retest-required

@dprotaso
Copy link
Member

dprotaso commented Oct 28, 2025

/retest

@dprotaso
Copy link
Member

dprotaso commented Oct 28, 2025

/retest

1 similar comment
@dprotaso
Copy link
Member

dprotaso commented Oct 28, 2025

/retest

@dprotaso
Copy link
Member

dprotaso commented Oct 28, 2025

@twoGiants I dunno what you want to do here - I pulled in required changes from knative/hack and knative-extensions/reconciler-test that I know are needed to get through CI but it's still failing so it now might be something with eventing.

Also with 1.20 coming out this week 1.18 becomes EOL. Unsure if you want to squeeze this in

@knative-prow
Copy link

knative-prow bot commented Oct 29, 2025

@twoGiants: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
reconciler-tests_eventing_release-1.18 601a9e5 link true /test reconciler-tests

Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

matzew
matzew approved these changes Oct 31, 2025
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2025
@knative-prow
Copy link

knative-prow bot commented Oct 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, twoGiants

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2025
@knative-prow knative-prow bot merged commit 53ba131 into knative:release-1.18 Oct 31, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matzew matzew matzew approved these changes

@aliok aliok Awaiting requested review from aliok

@mgencur mgencur Awaiting requested review from mgencur

Assignees

@matzew matzew

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@twoGiants @dprotaso @matzew