Eventing TLS: Add AddressableFromDestination method on the resolver

[pierDipi]

After #2711 is implemented, as the Eventing TLS feature track describes we should add a new method on the resolver as follow:

AddressableFromDestination(ctx Context, dest Destination, parent interface{}) (*Addressable, error)

The implementation should be similar to URIFromDestination

https://github.com/knative/pkg/blob/main/resolver/addressable_resolver.go#L75-L76C10

but with the following additional algorithm/logic:

• If status.addresses of the resolved destination is set (has at least 1 element)
  • if dest.ref.address is not specified:
    • Select the first (in order) address from all addresses
    • If no address is found use status.address of the resolved destination
  • else
    • Select the first (in order) address from all addresses with name == dest.ref.address
    • If no address is found return an error explaining that the address with name <address_value> cannot be found/resolved
• else return status.address of the resolved destination

Since the new AddressableFromDestination is a superset of URIFromDestination, the URIFromDestination should make use of the AddressableFromDestination method but return the resolved URI

Additional Info

• https://docs.google.com/document/d/1H-x_oji8LqkCyd7tlsSyclmUe7FAmEJPgRxOU_0pkn8/edit?resourcekey=0-lzDIPJsZOP3G17QE_g1lHw#

/good-first-issue
/kind feature
/area API

[knative-prow]

@pierDipi:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

Details

In response to this:

After #2711 is implemented, as the Eventing TLS feature track describes we should add a new method on the resolver as follow:

AddressableFromDestination(ctx Context, dest Destination, parent interface{}) (*Addressable, error)

The implementation should be similar to URIFromDestination

https://github.com/knative/pkg/blob/main/resolver/addressable_resolver.go#L75-L76C10

but with the following additional algorithm/logic:

• If status.addresses of the resolved destination is set (has at least 1 element)
• if dest.ref.address is not specified:
  • Select the first (in order) address from all addresses
  • If no address is found use status.address of the resolved destination
• else
  • Select the first (in order) address from all addresses with name == dest.ref.address
  • If no address is found return an error explaining that the address with name <address_value> cannot be found/resolved
• else return status.address of the resolved destination

Since the new AddressableFromDestination is a superset of URIFromDestination, the URIFromDestination should make use of the AddressableFromDestination method but return the resolved URI

Additional Info

• https://docs.google.com/document/d/1H-x_oji8LqkCyd7tlsSyclmUe7FAmEJPgRxOU_0pkn8/edit?resourcekey=0-lzDIPJsZOP3G17QE_g1lHw#

/good-first-issue
/kind feature
/area API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vishal-chdhry]

/assign