Skip to content

Fix golangci exclude config#15775

Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom
dsimansk:pr/fix-linter-config
Feb 14, 2025
Merged

Fix golangci exclude config#15775
knative-prow[bot] merged 1 commit intoknative:mainfrom
dsimansk:pr/fix-linter-config

Conversation

@dsimansk
Copy link
Contributor

Fixes #

Proposed Changes

  • Fix golangci exclude config

We had an issue downstream with linter and generated clients. Hence after comparing linter's configs, there's an issue with current one in Serving. PTAL

➜  serving git:(main) golangci-lint config verify
jsonschema: "run" does not validate with "/properties/run/additionalProperties": additional properties 'exclude-dirs' not allowed
Failed executing command with error: the configuration contains invalid elements
➜  serving git:(main) golangci-lint version
golangci-lint has version 1.63.4 built with go1.23.4 from c114969 on 2025-01-03T19:29:37Z

https://golangci-lint.run/usage/configuration/#issues-configuration

Release Note

Fix golangci exclude config

/assign @dprotaso

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 13, 2025
@knative-prow knative-prow bot requested review from dprotaso and skonto February 13, 2025 10:39
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2025
@codecov
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.83%. Comparing base (220c826) to head (5f6043b).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15775      +/-   ##
==========================================
+ Coverage   80.81%   80.83%   +0.01%     
==========================================
  Files         222      222              
  Lines       18075    18075              
==========================================
+ Hits        14608    14611       +3     
+ Misses       3096     3094       -2     
+ Partials      371      370       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto
Copy link
Contributor

skonto commented Feb 13, 2025

    service_test.go:437: error with initial domain probing: response: status: 200, body: What a spaceport!, headers: map[Content-Length:[17] Content-Type:[text/plain; charset=utf-8] Date:[Thu, 13 Feb 2025 10:52:46 GMT] Server:[envoy] X-Envoy-Upstream-Service-Time:[2] Zipkin_trace_id:[04459eddd590a11ad02fa3a0e6682928]] did not pass checks: body = What a spaceport!, want one of: [Re-energize yourself with a slice of pepperoni!]

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2025
@knative-prow
Copy link

knative-prow bot commented Feb 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 8a665f2 into knative:main Feb 14, 2025
64 checks passed
@dsimansk dsimansk deleted the pr/fix-linter-config branch February 17, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants