Change multiplicative generator of bn254 to 5 instead of 7#18
Open
jbaylina wants to merge 1 commit into
Open
Conversation
kobigurk
approved these changes
Jun 19, 2020
Owner
kobigurk
left a comment
kobigurk
left a comment
There was a problem hiding this comment.
Thanks. I agree that it's best the whole community works with one generator.
|
@jbaylina : beginner question : why is it important for the value to be the same as other libraries ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the field Fr of the curve bn254 the lowest generator is 5 instead of 7.
This is the standard used in other libraries.
See:
This PR breaks backwards compatibility, but I believe it's important to fix it ASAP so we use 5 for the new circuits.