ENH: add __array_api_version__ #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* this is in part a copy of the NumPy patch applied at: numpy/numpy#22365 and is related to this failure we were seeing with `hypothesis`: kokkos#65 (comment) * the standard section related to this is: https://data-apis.org/array-api/latest/future_API_evolution.html#versioning * unpin `hypothesis` in our CI as a result; to be fair, this is the solution @ShahzadUmair wanted from the start I think * the updated testing behavior required me to cherry-pick some data type info improvements from kokkosgh-97
NaderAlAwar
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is in part a copy of the NumPy patch applied at: BUG: Add
__array_api_version__tonumpy.array_apinamespace numpy/numpy#22365and is related to this failure we were seeing with
hypothesis: ENH: array API "namespace" #65 (comment)the standard section related to this is: https://data-apis.org/array-api/latest/future_API_evolution.html#versioning
unpin
hypothesisin our CI as a result; to be fair, this is the solution @ShahzadUmair wanted from the start I thinkthe updated testing behavior required me to cherry-pick some data type info improvements from ENH: isfinite() to API std #97