[64.3] CJ0050: suggest named extension property when common .Where() pattern detected#131
Merged
kommundsen merged 1 commit intomainfrom Apr 10, 2026
Conversation
…() patterns - Detects 5 blessed predicates on Strategy<T>: x > 0, x < 0, x != 0, x.Length > 0, x.Count > 0 — suggests Positive, Negative, NonZero, NonEmpty - Code fix in CJ0050CodeFix replaces the .Where(lambda) call with the named property - Syntactic fallback for test harnesses where semantic model can't resolve Strategy<T> - Diagnostic is Info severity; does not fire on unrelated IEnumerable<T>.Where()
kommundsen
deleted the
feat/64-126-cj0050-extension-property-suggestion-analyzer
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
CJ0050Analyzer(Info severity) that detects five blessed.Where()predicate patterns onStrategy<T>and suggests the named extension property equivalent (Positive,Negative,NonZero,NonEmpty). A companionCJ0050CodeFixreplaces the.Where(lambda)call with the named property in one action.Pattern matching is structural (parameter-name-agnostic). A syntactic fallback handles test harnesses where the semantic model cannot resolve
Strategy<T>due to namespace conflicts. The diagnostic does not fire on unrelatedIEnumerable<T>.Where()calls.Type of change
Checklist
dotnet test src/passes.editorconfigcode styleCloses #126
Part of #64