Merged
Conversation
This works around the issue that module-info files are wrongly detected as duplicates. Required for using Junit5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JUnit 5 has a few gimmicks like parametrized tests that I'm looking forward to use. This PR just contains the necessary syntax changes to run our tests under JUnit5. With our rather basic use of the test framework, there are no bigger changes necessary on that side.
I did run into the problem again with ES' JarHell wrongly detecting the module-info as a duplicate. To work around that the tests now come with a patched version of the JarHell.java file that has a backport of the changes in elastic/elasticsearch#33011 to ES 5.6. It ignores module-info and JarHell.java files (because, being a good duplicate detector, it detects itself correctly as a duplicate). It's a good-enough workaround for the tests but not really something I would want to use on the binary.