FIX #162 - removed "*." added by client.py, removed often incomplete …#163
Merged
mmaney merged 2 commits intokomuw:masterfrom Apr 10, 2020
Merged
FIX #162 - removed "*." added by client.py, removed often incomplete …#163mmaney merged 2 commits intokomuw:masterfrom
mmaney merged 2 commits intokomuw:masterfrom
Conversation
…lete fixes from most providers.
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
==========================================
+ Coverage 86.70% 86.71% +0.01%
==========================================
Files 18 18
Lines 1038 1024 -14
==========================================
- Hits 900 888 -12
+ Misses 138 136 -2
Continue to review full report at Codecov.
|
Owner
|
Clones removed
==============
+ sewer/dns_providers/tests/test_hedns.py -2
+ sewer/dns_providers/tests/test_aliyundns.py -2
See the complete overview on Codacy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…fixes from most providers.
Contributor offers to license certain software (a “Contribution” or multiple “Contributions”) to sewer, and sewer agrees to accept said Contributions, under the terms of the MIT License.
Contributor understands and agrees that sewer shall have the irrevocable and perpetual right to make and distribute copies of any Contribution, as well as to create and distribute collective works and derivative works of any Contribution, under the MIT License.
What(What have you changed?)
Removed prepending of "*." to wildcard domains in
Client.get_identifier_authorizationto fix #162 as well as several other providers that appear to have the same problem but no open bug I can find.Why(Why did you change it?)
8 of 11 providers had the obvious
domain_name.lstrip("*')patch, though several only apply that to adding domains, and so probably fail when deleting them (may not be checked & reported in the driver?). One other achieved the same removal in a different way. The two that didn't were rout53 (cause of the cited bug report) and powerdns, which is a fairly new driver and certainly looks like it would fail to handle "*.domain.tld". Would love to hear from @kylejohnson about that one.