Skip to content

fix: config should be _ instead of -#604

Closed
patrick330602 wants to merge 1 commit intokovetskiy:masterfrom
patrick330602:fix/doc-config
Closed

fix: config should be _ instead of -#604
patrick330602 wants to merge 1 commit intokovetskiy:masterfrom
patrick330602:fix/doc-config

Conversation

@patrick330602
Copy link
Contributor

config demonstrated on README should be _ instead of -

@mrueg
Copy link
Collaborator

mrueg commented Jun 4, 2025

these are aliased, so the hyphenated version should work as well (or did you run into issues here?)

@patrick330602
Copy link
Contributor Author

these are aliased, so the hyphenated version should work as well (or did you run into issues here?)

no, in the code they are underscore only and it won't read until I switched from - to _

initially I have trouble using base-url in toml since it never sets until I see this: https://github.com/kovetskiy/mark/blob/master/util/flags.go#L127

which is underline only, which all others are in similar situation

@mrueg
Copy link
Collaborator

mrueg commented Jun 6, 2025

Thanks for looking into it and the PR!

Looks like I made some mistakes in the the migration to urfave/cli/v3. #606 should fix it (and make things hopefully less confusing if everything is hyphenated).

@mrueg mrueg closed this Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants