fix: config should be _ instead of -#604
Closed
patrick330602 wants to merge 1 commit intokovetskiy:masterfrom
patrick330602:fix/doc-config
Closed
fix: config should be _ instead of -#604patrick330602 wants to merge 1 commit intokovetskiy:masterfrom patrick330602:fix/doc-config
patrick330602 wants to merge 1 commit intokovetskiy:masterfrom
patrick330602:fix/doc-config
Conversation
Collaborator
|
these are aliased, so the hyphenated version should work as well (or did you run into issues here?) |
Contributor
Author
no, in the code they are underscore only and it won't read until I switched from - to _ initially I have trouble using base-url in toml since it never sets until I see this: https://github.com/kovetskiy/mark/blob/master/util/flags.go#L127 which is underline only, which all others are in similar situation |
Collaborator
|
Thanks for looking into it and the PR! Looks like I made some mistakes in the the migration to urfave/cli/v3. #606 should fix it (and make things hopefully less confusing if everything is hyphenated). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
config demonstrated on README should be _ instead of -