Initialize D2Scale configuration member#611
Merged
mrueg merged 1 commit intokovetskiy:masterfrom Jun 12, 2025
Merged
Conversation
The D2Scale property of MarkConfig was never initialized, leading to a default value of 0 being passed to the D2 renderer. This eventually led to calling chromedp.ScreenshotScale with a scale value of 0. Chrome doesn't like this, and never finishes the sceenshot operation. Fixes kovetskiy#610
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The D2Scale property of MarkConfig was never initialized, leading to a default value of 0 being passed to the D2 renderer. This eventually led to calling chromedp.ScreenshotScale with a scale value of 0. Chrome doesn't like this, and never finishes the sceenshot operation.
Fixes #610