Add a search_type filter for exact, contains and startsWith search modes#217
Open
cen1 wants to merge 1 commit intokpcyrd:mainfrom
Open
Add a search_type filter for exact, contains and startsWith search modes#217cen1 wants to merge 1 commit intokpcyrd:mainfrom
cen1 wants to merge 1 commit intokpcyrd:mainfrom
Conversation
Contributor
Author
|
Added some integration tests, I think it should be g2g. |
86b6e2d to
0e44986
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
nameparam returns package by exact match however, I needed a more extended functionality on my FE to search by partial match and a "starts with" for an Alphabet filter.I could have just changed how the name filter works (make the value a LIKE syntax value for example) but that would break backward compat. Second option was to add a new search param like
name_starts_with, but then I decided on a third option to switch between modes and haveexactbe the default.Could possibly need to have to name this
name_search_typeif you'd want to do something similar with another field (version?) but not seeing a use case rn.Client side: