fix: add function comments to functions within scheduler#332
Merged
Britania Rodriguez Reyes (britaniar) merged 1 commit intokubefleet-dev:mainfrom Nov 18, 2025
Merged
Conversation
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Britania Rodriguez Reyes (britaniar)
requested a review
from Zhiying Lin (zhiying-lin)
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Zhiying Lin (zhiying-lin)
approved these changes
Nov 18, 2025
Britania Rodriguez Reyes (britaniar)
merged commit 4ce199e
into
kubefleet-dev:main
13 of 15 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
I have:
addressed comments from previous PR: https://github.com/kubefleet-dev/kubefleet/pull/330/files
Run
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer