feat: stopped update run implementation#364
Merged
britaniar merged 16 commits intokubefleet-dev:mainfrom Dec 11, 2025
Merged
Conversation
britaniar
force-pushed
the
stoppedUpdateRun
branch
from
6443aa1 to
c29ae9b
Compare
Arvindthiru
reviewed
Dec 5, 2025
Arvindthiru
reviewed
Dec 5, 2025
Arvindthiru
reviewed
Dec 5, 2025
Arvindthiru
reviewed
Dec 5, 2025
Arvindthiru
reviewed
Dec 5, 2025
Arvindthiru
reviewed
Dec 5, 2025
Arvindthiru
reviewed
Dec 5, 2025
Arvindthiru
reviewed
Dec 5, 2025
Arvindthiru
reviewed
Dec 6, 2025
Arvindthiru
reviewed
Dec 6, 2025
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
britaniar
force-pushed
the
stoppedUpdateRun
branch
from
2b10b54 to
b0b9ea0
Compare
Arvindthiru
reviewed
Dec 8, 2025
Arvindthiru
reviewed
Dec 8, 2025
Arvindthiru
reviewed
Dec 8, 2025
Arvindthiru
reviewed
Dec 8, 2025
Arvindthiru
reviewed
Dec 8, 2025
Arvindthiru
reviewed
Dec 8, 2025
Arvindthiru
reviewed
Dec 8, 2025
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
jwtty
reviewed
Dec 9, 2025
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Arvindthiru
reviewed
Dec 10, 2025
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Arvindthiru
reviewed
Dec 10, 2025
Arvindthiru
reviewed
Dec 10, 2025
jwtty
reviewed
Dec 10, 2025
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Arvindthiru
reviewed
Dec 11, 2025
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
ryanzhang-oss
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
I have:
Updates the update run condition to be stopped when state is "Stop"
Updates the overall existing conditions to match the current update run generation at the beginning of the reconcile to match k8s ObservedGeneration functionality.
Updated integration tests and e2e tests.
Run
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer
"Stopping" implementation will be in a follow up PR (lets cluster finish updating and then updates the stage conditions).