fix: fix update run name CEL#384
Merged
Ryan Zhang (ryanzhang-oss) merged 1 commit intokubefleet-dev:mainfrom Dec 18, 2025
Merged
fix: fix update run name CEL#384Ryan Zhang (ryanzhang-oss) merged 1 commit intokubefleet-dev:mainfrom
Ryan Zhang (ryanzhang-oss) merged 1 commit intokubefleet-dev:mainfrom
Conversation
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Ryan Zhang (ryanzhang-oss)
approved these changes
Dec 18, 2025
71b330f
into
kubefleet-dev:main
17 checks passed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
I have:
Updated the CEL validation for the update run name. The name cannot be longer than 63 characters.
Run
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer
Create a clusterStagedUpdateRun with the max characters allowed which is 127 based on the CEL check. When the controller tried to create the cluster approval request I got this error:
Seems like the cap for the update run name should be 63 characters not 127 so that it fits in the label.
kubefleet/pkg/controllers/updaterun/execution.go
Line 632 in 6f3e972
Label Values need to be <= 63 characters (https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#syntax-and-character-set)