fix: use the correct client in work applier ITs and set a longer timeout#390
Merged
michaelawyu merged 5 commits intokubefleet-dev:mainfrom Dec 23, 2025
Merged
Conversation
Signed-off-by: michaelawyu <chenyu1@microsoft.com>
zhiying-lin
reviewed
Dec 22, 2025
Signed-off-by: michaelawyu <chenyu1@microsoft.com>
…x/allow-longer-UT-IT-timeout
Signed-off-by: michaelawyu <chenyu1@microsoft.com>
michaelawyu
changed the title
michaelawyu
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
zhiying-lin
approved these changes
Dec 23, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR addresses the following issues:
a) a utility used in the work applier ITs is set to use a client for a specific env statically;
b) the work applier ITs might time out given the current setting (20 min).
Will submit subsequent PRs to run ITs via
ginkgoCLI instead ofgo testand enable parallelization properly.I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
N/A
Special notes for your reviewer
N/A