test: fix flaky report diff e2e#391
Merged
michaelawyu merged 1 commit intokubefleet-dev:mainfrom Dec 23, 2025
Merged
Conversation
Signed-off-by: Wantong Jiang <wantjian@microsoft.com>
michaelawyu
approved these changes
Dec 23, 2025
Member
michaelawyu
left a comment
michaelawyu
left a comment
There was a problem hiding this comment.
Hi Wantong! Thanks for this; LGTM, I am thinking that for our E2E we probably need to use a different backoff setup...
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fix flaky report-diff e2e like https://github.com/kubefleet-dev/kubefleet/actions/runs/20232703043/job/58149088651?pr=379. The root cause is that with workapplier backoff requeue enabled, the default eventual duration may not be able to cover the backoff delay so new diff may not be reflected yet.
-->
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer