feat: improve the default setup for hub agent leader election to allow better scalability/stability#414
Conversation
Signed-off-by: michaelawyu <chenyu1@microsoft.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…o feat/tweak-leader-election-settings
Signed-off-by: michaelawyu <chenyu1@microsoft.com>
Signed-off-by: michaelawyu <chenyu1@microsoft.com>
| &o.LeaseDuration.Duration, | ||
| "leader-lease-duration", | ||
| 15*time.Second, | ||
| 90*time.Second, |
There was a problem hiding this comment.
have we tested this value? It seems a bit high
There was a problem hiding this comment.
Hi Ryan! In the performance test we used a value even higher (180s), but if 90 secs is a concern, would you like me to lower this to 60 secs?
The requirement is basically the lease duration must be higher than the renew deadline.
There was a problem hiding this comment.
Or to be on the safer side, would it be better if we rollout this in multiple stages?
e.g.,
for now, set things to 30 seconds/25 seconds/5 seconds; when it rolls out fully,
next, set things to 45 seconds/40 seconds/5 seconds; ...
It shouldn't affect our performance test plan -> I could do an override on that specific environment.
There was a problem hiding this comment.
Got it. Has tweaked the numbers.
Signed-off-by: michaelawyu <chenyu1@microsoft.com>
Description of your changes
This PR makes the following changes:
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
N/A
Special notes for your reviewer
Please refer to the Jan 2026 performance test report for more information.