feat: add validator functions for placement disruption budget to use in webhook#68
Merged
britaniar merged 11 commits intokubefleet-dev:mainfrom May 27, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
britaniar
force-pushed
the
crpdbValidation
branch
from
e251825 to
e14760b
Compare
Arvindthiru
reviewed
May 20, 2025
Arvindthiru
reviewed
May 20, 2025
...lacementdisruptionbudget/clusterresourceplacementdisruptionbudget_validating_webhook_test.go
Outdated
Show resolved
Hide resolved
Arvindthiru
reviewed
May 22, 2025
...lacementdisruptionbudget/clusterresourceplacementdisruptionbudget_validating_webhook_test.go
Outdated
Show resolved
Hide resolved
Arvindthiru
reviewed
May 22, 2025
...lacementdisruptionbudget/clusterresourceplacementdisruptionbudget_validating_webhook_test.go
Outdated
Show resolved
Hide resolved
Arvindthiru
reviewed
May 23, 2025
...urceplacementdisruptionbudget/clusterresourceplacementdisruptionbudget_validating_webhook.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
britaniar
force-pushed
the
crpdbValidation
branch
from
22d65d9 to
ed3bbf2
Compare
Arvindthiru
reviewed
May 23, 2025
...urceplacementdisruptionbudget/clusterresourceplacementdisruptionbudget_validating_webhook.go
Outdated
Show resolved
Hide resolved
Arvindthiru
reviewed
May 23, 2025
...hook/clusterresourceplacementeviction/clusterresourceplacementeviction_validating_webhook.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Arvindthiru
reviewed
May 23, 2025
...clusterresourceplacementeviction/clusterresourceplacementeviction_validating_webhook_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Arvindthiru
reviewed
May 27, 2025
| Name: "crp-pickn", | ||
| }, | ||
| Spec: placementv1beta1.PlacementDisruptionBudgetSpec{ | ||
| MaxUnavailable: &intstr.IntOrString{ |
Member
There was a problem hiding this comment.
We can't specify both MaxUnavailable and MinAvailable in a valid CRPDB, can be handled in follow up PR
1 task
audrastump
pushed a commit
to audrastump/kubefleet
that referenced
this pull request
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer