feat: support multi-version reporting in CRP for updateRun#72
Merged
jwtty merged 4 commits intokubefleet-dev:mainfrom Jun 2, 2025
Merged
feat: support multi-version reporting in CRP for updateRun#72jwtty merged 4 commits intokubefleet-dev:mainfrom
jwtty merged 4 commits intokubefleet-dev:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
jwtty
force-pushed
the
crp-status
branch
18 times, most recently
from
f9d1f6a to
cdc531d
Compare
| } | ||
|
|
||
| // TODO (wantjian): we only change the per-cluster status for External rollout strategy for now, so set the ObservedResourceIndex as the latest. | ||
| status.ObservedResourceIndex = latestResourceSnapshot.GetLabels()[fleetv1beta1.ResourceIndexLabel] |
Member
There was a problem hiding this comment.
what does this TODO mean? Are we going to set per-cluster status for rollingUpdate too?
Collaborator
Author
There was a problem hiding this comment.
Yes, per our original discussion, we show the version existing on the binding for both External and rollingUpdate. This PR does not change the rollingUpdate one as without portal update to display the ObservedResourceIndex, it will look very weird to users: the status is available but it's actually available on a not-shown older version.
jwtty
force-pushed
the
crp-status
branch
2 times, most recently
from
75aa293 to
13ee5b1
Compare
Signed-off-by: Wantong Jiang <wantjian@microsoft.com>
Signed-off-by: Wantong Jiang <wantjian@microsoft.com>
Signed-off-by: Wantong Jiang <wantjian@microsoft.com>
Signed-off-by: Wantong Jiang <wantjian@microsoft.com>
ryanzhang-oss
approved these changes
Jun 2, 2025
This was referenced Jun 4, 2025
audrastump
pushed a commit
to audrastump/kubefleet
that referenced
this pull request
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
When CRP sets rollout strategy type to
Externaland thus rollout is controlled by an external controller, e.g. an updateRun, the CRP controller cannot make assumption about the real rollout intent and thus should not blindly report progress based on the latest resource snapshot.This PR fixes by populating the
ObservedResourceIndexfield in per-clusterResourcePlacementStatus, showing the whatever exists on the cluster's binding when the rollout type is set to External. And only report CRP availability when all selected clusters observe the same resource index. This essentially supports demonstrating CRP status correctly during rollout and rollback with updateRuns.Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer