test: improve the join and leave tests#73
Merged
ryanzhang-oss merged 6 commits intokubefleet-dev:mainfrom Jun 3, 2025
Merged
Conversation
zhiying-lin
force-pushed
the
add-leave-test
branch
from
638462e to
ec09e9f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Member
|
Is there a way to get the agent to run the e2e and fix it? |
Member
|
LGTM ;) Though it seems that the namespace GC flakiness issue raises up again |
ryanzhang-oss
force-pushed
the
add-leave-test
branch
from
41156ca to
b0a40d8
Compare
Signed-off-by: Ryan Zhang <zhangryan@microsoft.com> Signed-off-by: Zhiying Lin <zhiyingl456@gmail.com>
Signed-off-by: Zhiying Lin <zhiyingl456@gmail.com>
zhiying-lin
force-pushed
the
add-leave-test
branch
from
7626e10 to
a59ab00
Compare
zhiying-lin
commented
May 29, 2025
Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com>
zhiying-lin
commented
May 30, 2025
pkg/scheduler/watchers/membercluster/controller_integration_test.go
Outdated
Show resolved
Hide resolved
michaelawyu
reviewed
May 30, 2025
pkg/scheduler/watchers/membercluster/controller_integration_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com>
Signed-off-by: Ryan Zhang <zhangryan@microsoft.com>
ryanzhang-oss
force-pushed
the
add-leave-test
branch
from
467f7bf to
d2159b8
Compare
This was referenced Jun 4, 2025
audrastump
pushed a commit
to audrastump/kubefleet
that referenced
this pull request
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
to validate whether the resources are left on the members or not
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer