feat: add the resource placement related API#82
feat: add the resource placement related API#82ryanzhang-oss merged 2 commits intokubefleet-dev:mainfrom
Conversation
86110a9 to
88caf94
Compare
Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com>
88caf94 to
6c54711
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the namespaced resource placement API types while renaming several ClusterResourcePlacement-related types to more generic Placement types. Key changes include the renaming of specifications and statuses from ClusterResourcePlacementSpec/Status to PlacementSpec/Status across controllers and tests, updates to CRD YAML files to reflect new labels and naming conventions, and modifications to API types and their deepcopy functions.
Reviewed Changes
Copilot reviewed 56 out of 56 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/controllers/clusterresourceplacementwatcher/watcher_integration_test.go | Renames resource spec type to PlacementSpec in test setup. |
| pkg/controllers/clusterresourceplacementeviction/* | Updates spec type to PlacementSpec in multiple test cases. |
| pkg/controllers/clusterresourceplacement/placement_status_test.go | Adjusts status type from ClusterResourcePlacementStatus to PlacementStatus. |
| pkg/controllers/clusterresourceplacement/* | Applies similar renaming in controller tests and integration tests. |
| config/crd/bases/* | Updates CRD definitions to use new labels (e.g. PlacementTrackingLabel) and removes redundant comments. |
| apis/placement/v1beta1/* | Renames API type fields and updates deepcopy functions and comments to reflect the new Placement API, as well as adjusting comments regarding tracking labels. |
| .github/.copilot/breadcrumbs/* | Documentation update that details the implementation and registration of new namespace-scoped types. |
Comments suppressed due to low confidence (1)
pkg/controllers/clusterresourceplacementeviction/controller_intergration_test.go:0
- Consider renaming the file to 'controller_integration_test.go' to correct the spelling of 'integration'.
controller_intergration_test.go
Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Description of your changes
Add the namespaced resource placement API with some rename
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer