OAS: fix minor issues and bump version#29
OAS: fix minor issues and bump version#29google-oss-prow[bot] merged 3 commits intokubeflow:mainfrom
Conversation
... to preserve camelCase. Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com>
Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com>
|
@isinyaaa based on: https://github.com/kubeflow/model-registry/actions/runs/8204093394/job/22438052976?pr=29#step:9:1 would look like go codegen was not fully committed; I remember sometimes this was a different behaviour of codegen on my Mac machine "Vs" @lampajr Fedora machine, so in case could be the changed I introduced with 9a51c58 are not ordered correctly if compared to main. edit: thank you for making me notice, in this case highlights the protobuf version used on the machine was different ✍️ |
tarilabs
left a comment
There was a problem hiding this comment.
Start by replacing ID -> Id to preserve camelCase. Then fix
PATCH /model_versions/{mv_id} to take in a ModelVersionUpdate.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: isinyaaa, tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* This commit will update the iib for odh-nightly build and fix the paths as the script will be run from the root of the repo instead of directly from the host directory * This commit removes color text from echo statements
Start by replacing
ID->Idto preserve camelCase. Then fixPATCH /model_versions/{mv_id}to take in aModelVersionUpdate.Description
Some code generators, especially in languages that use snake case, will turn those parameter names to e.g.
external_i_d, which is unexpected. We also get type issues when using aModelVersionUpdate, as there's no route that takes it.How Has This Been Tested?
Following the same steps laid out on the last PR referencing OAS #17:
then,
make proxyrobot test/robot/ && TEST_MODE=python robot test/robot/MRandLogicalModel.robotMerge criteria: