Added OnError event to MetaObjectLock

[fh-tmccurdy]

Exposes HTTP operation exceptions for logging or tracing.

Fixes #1584

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: fh-tmccurdy / name: Tim McCurdy (e396bd9, 4835a2c)

[k8s-ci-robot]

Welcome @fh-tmccurdy!

It looks like this is your first PR to kubernetes-client/csharp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/csharp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[brendandburns]

Looks ok to me. I'll wait for input from @tg123

You'll need to sign our CLA.

[WeihanLi]

What about OnHttpError？

[fh-tmccurdy]

I did consider it, so happy to use it if everyone agrees. I was just trying to match LeaderElectors event name.

[tg123]

what about Action<Exception> OnError
to align with all other OnError in this libarary

[fh-tmccurdy]

I've changed it to OnHttpError for now.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@f5fee73). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...ient/LeaderElection/ResourceLock/MetaObjectLock.cs	0.00%	4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #1585   +/-   ##
=========================================
  Coverage          ?   61.47%           
=========================================
  Files             ?      103           
  Lines             ?     3071           
  Branches          ?      641           
=========================================
  Hits              ?     1888           
  Misses            ?     1183           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[fh-tmccurdy]

/approve

[tg123]

/LGTM

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fh-tmccurdy, tg123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [tg123]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment