Order YAML type meta fields before resource data#1717
Merged
k8s-ci-robot merged 3 commits intomasterfrom Feb 15, 2026
Merged
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
Co-authored-by: tg123 <170430+tg123@users.noreply.github.com>
k8s-ci-robot
added
size/M
Copilot
AI
changed the title
[WIP] Fix cloning YAML.go functionality in C# SDK
Order YAML type meta fields before resource data
Jan 19, 2026
Member
|
@copilot Fix pipelines |
Co-authored-by: tg123 <170430+tg123@users.noreply.github.com>
Contributor
Author
Fixed the pipeline StyleCop SA1513 issue by adding the required blank line in KubernetesYaml.cs. Commit: 38a5ce3. No UI changes. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #1715 by implementing property ordering for Kubernetes YAML serialization, ensuring TypeMeta fields (apiVersion, kind, metadata) appear before resource-specific data fields. This matches the behavior of the Kubernetes Go client's CLI runtime printer.
Changes:
- Modified
WithOverridesFromJsonPropertyAttributesto assign explicit order values to properties in types with ApiVersion/Kind fields - Updated existing tests to expect the new property ordering
- Added new test
WriteConfigMapOrdersTypeMetaFirstto explicitly verify the ordering behavior
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/KubernetesClient/KubernetesYaml.cs | Implements property ordering logic using YamlMemberAttribute.Order for types with ApiVersion/Kind, ensuring TypeMeta fields (ApiVersion, Kind, Metadata) are serialized first, followed by other properties in metadata token order |
| tests/KubernetesClient.Tests/KubernetesYamlTests.cs | Updates WriteSecret and WriteConfigMap test expectations to match new property ordering, and adds WriteConfigMapOrdersTypeMetaFirst test to verify the feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Copilot, tg123 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.