Skip to content

Enable unnecessary code rules#799

Merged
k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
stan-sz:stan-sz/798
Mar 22, 2022
Merged

Enable unnecessary code rules#799
k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
stan-sz:stan-sz/798

Conversation

@stan-sz
Copy link
Contributor

@stan-sz stan-sz commented Mar 21, 2022

Closes: #798

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Mar 21, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 21, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 21, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 21, 2022

Welcome @stan-sz!

It looks like this is your first PR to kubernetes-client/csharp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/csharp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 21, 2022
@stan-sz
Enable some of the unnecessary code rules
34dbd31 
* CA1823 Avoid unused private fields
* CA1847 Use string.Contains(char) instead of string.Contains(string) with single characters
* IDE0005 Remove unnecessary import
* IDE0051 Private member is unused
* IDE0052 Private member is unread
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Mar 21, 2022
@stan-sz
Copy link
Contributor Author

stan-sz commented Mar 21, 2022

/assign tg123

@tg123
Copy link
Member

tg123 commented Mar 21, 2022

/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2022
WeihanLi
WeihanLi reviewed Mar 22, 2022
View reviewed changes
.editorconfig
# https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/unnecessary-code-rules

# Avoid unused private fields
dotnet_diagnostic.CA1823.severity = error
Copy link
Contributor

@WeihanLi WeihanLi Mar 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe better add a document link
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/

@brendandburns
Copy link
Contributor

brendandburns commented Mar 22, 2022

/lgtm
/approve

Thanks!

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, stan-sz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit 624ee29 into kubernetes-client:master Mar 22, 2022
@WeihanLi WeihanLi mentioned this pull request Mar 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@krabhishek8260 krabhishek8260 Awaiting requested review from krabhishek8260

1 more reviewer

@WeihanLi WeihanLi WeihanLi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tg123 tg123

@brendandburns brendandburns

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable 'unnecessary code' analysis rules

5 participants

@stan-sz @k8s-ci-robot @tg123 @brendandburns @WeihanLi