Skip to content

Set http 2.0 for .net 5.0+#833

Merged
k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
zhiweiv:http2
Apr 19, 2022
Merged

Set http 2.0 for .net 5.0+#833
k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
zhiweiv:http2

Conversation

@zhiweiv
Copy link
Contributor

@zhiweiv zhiweiv commented Apr 19, 2022

In #808, http 2 was omitted on .net 5.0+, this causes watch hang because httpclient keepalive only work on http 2.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 19, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 19, 2022
tg123
tg123 approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@tg123 tg123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tg123, zhiweiv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2022
@zhiweiv
Copy link
Contributor Author

zhiweiv commented Apr 19, 2022

@tg123
I am wondering, should all NETSTANDARD2_1_OR_GREATER be replaced to NETSTANDARD2_1_OR_GREATER || NET5_0_OR_GREATER?

There are another three in https://github.com/kubernetes-client/csharp/blob/master/src/KubernetesClient/Authentication/TokenFileAuth.cs.

@k8s-ci-robot k8s-ci-robot merged commit 199ec8b into kubernetes-client:master Apr 19, 2022
@zhiweiv zhiweiv deleted the http2 branch April 19, 2022 08:05
@tg123
Copy link
Member

tg123 commented Apr 19, 2022

@zhiweiv you are right, lets fix them as well
I am thinking adding a test to enforce http2

@zhiweiv
Copy link
Contributor Author

zhiweiv commented Apr 19, 2022

I will submit another PR to update remains, this is only for watch hang issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tg123 tg123 tg123 approved these changes

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@tg123 tg123

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhiweiv @k8s-ci-robot @tg123