Skip to content

Allow configurable Http KeepAlive parameters#837

Merged
k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
Paciv:KeepAliveConfig
Apr 21, 2022
Merged

Allow configurable Http KeepAlive parameters#837
k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
Paciv:KeepAliveConfig

Conversation

@Paciv
Copy link
Contributor

@Paciv Paciv commented Apr 21, 2022

No description provided.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 21, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 21, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 21, 2022

Welcome @Paciv!

It looks like this is your first PR to kubernetes-client/csharp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/csharp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 21, 2022
tg123
tg123 reviewed Apr 21, 2022
View reviewed changes
@Paciv Paciv force-pushed the KeepAliveConfig branch 2 times, most recently from bd9f94c to 9d9a16e Compare April 21, 2022 07:29
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 21, 2022
tg123
tg123 reviewed Apr 21, 2022
View reviewed changes
Copy link
Member

@tg123 tg123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR
could you please sign CLA?

@Paciv Paciv force-pushed the KeepAliveConfig branch from 9d9a16e to 1c9a6db Compare April 21, 2022 09:49
@Paciv Paciv force-pushed the KeepAliveConfig branch from 1c9a6db to 3424170 Compare April 21, 2022 12:08
@tg123
Copy link
Member

tg123 commented Apr 21, 2022

Thanks and welcome
/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Paciv, tg123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2022
@k8s-ci-robot k8s-ci-robot merged commit f9985ed into kubernetes-client:master Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tg123 tg123 tg123 approved these changes

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@tg123 tg123

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Paciv @k8s-ci-robot @tg123