Close the Python sockets when the Websocket closes#2316
Close the Python sockets when the Websocket closes#2316k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
Conversation
This allows the client to detect when the connection has been interrupted
The committers listed above are authorized under a signed CLA. |
|
Welcome @anvilpete! |
|
/assign |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anvilpete, roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
If the websocket connection to the k8s API server is closed for any reason, the library currently throws a
WebSocketConnectionClosedExceptionin the PortForward proxy thread and hangs.This PR catches this exception and closes the Python-side local sockets associated with the websocket. This lets the client application detect that the connection has been interrupted.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: