Remove duplicate code in connection package#31
Remove duplicate code in connection package#31k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
Conversation
There are duplicate functions present in both rpc and connection package. This PR removes the duplicate code from connection package. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
|
Hi @Madhu-1. Thanks for your PR. I'm waiting for a kubernetes-csi or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @msau42 |
|
/ok-to-test |
pohly
left a comment
There was a problem hiding this comment.
The changelog needs to be updated. The second sentence should be "The rpc package has the same code."
|
@pohly Thanks for the review, updated changelog |
|
/kind cleanup |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Madhu-1, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
There are duplicate functions present in both rpc and connection package. This PR removes the duplicate code from connection package.
Signed-off-by: Madhu Rajanna madhupr007@gmail.com
Which issue(s) this PR fixes:
Fixes #30
Special notes for your reviewer:
Does this PR introduce a user-facing change?: