✨ Only set ownerReference on InfraCluster/ControlPlane when Topology is defined#13332
Merged
k8s-ci-robot merged 4 commits intokubernetes-sigs:mainfrom Mar 10, 2026
Merged
Conversation
k8s-ci-robot
added
size/L
sbueringer
reviewed
Feb 18, 2026
sbueringer
reviewed
Feb 24, 2026
sbueringer
reviewed
Feb 24, 2026
Member
|
/test pull-cluster-api-e2e-main-gke |
sivchari
force-pushed
the
fix-metacontroller-compatibility
branch
from
f944317 to
1cdabc3
Compare
sbueringer
added
the
tide/merge-method-squash
sbueringer
reviewed
Mar 7, 2026
Member
There was a problem hiding this comment.
Please also adjust this
(currently we don't hit the no-op code path if the cluster is not topology managed)
sivchari
force-pushed
the
fix-metacontroller-compatibility
branch
from
1cdabc3 to
938c734
Compare
Member
… defined Signed-off-by: sivchari <shibuuuu5@gmail.com>
…s not defined Address review feedback: ownerReference should always be set for cascade deletion. When Topology is defined, use SetControllerReference (controller: true) so CAPI fully manages the lifecycle. When Topology is not defined, use SetOwnerReference (controller: false) to enable cascade deletion while allowing external tools to set their own controller ownerReference.
Signed-off-by: sivchari <shibuuuu5@gmail.com>
Signed-off-by: sivchari <shibuuuu5@gmail.com>
sivchari
force-pushed
the
fix-metacontroller-compatibility
branch
from
938c734 to
541de6b
Compare
Member
Author
|
/test pull-cluster-api-e2e-main-gke |
Member
|
Thank you very much!! /lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: a7928d51586879a69d04c39d5c552b95f219c810 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #13256