Skip to content

🌱 Stop using patch helper when enforcing finalizers#13365

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
fabriziopandini:improve-enforce-finalizer
Feb 20, 2026
Merged

🌱 Stop using patch helper when enforcing finalizers#13365
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
fabriziopandini:improve-enforce-finalizer

Conversation

@fabriziopandini
Copy link
Copy Markdown
Member

@fabriziopandini fabriziopandini commented Feb 20, 2026

What this PR does / why we need it:
EnsureFinalizer is patching only a field, patch helper is overkill

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #13305

/area util

@k8s-ci-robot k8s-ci-robot added the area/util Issues or PRs related to utils label Feb 20, 2026
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 20, 2026
@sbueringer
Copy link
Copy Markdown
Member

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 05d5e76894249bffe747ac6a22025701e09e5f70

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2026
@k8s-ci-robot k8s-ci-robot merged commit 9933ac8 into kubernetes-sigs:main Feb 20, 2026
20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Feb 20, 2026
@sbueringer sbueringer mentioned this pull request Feb 20, 2026
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/util Issues or PRs related to utils cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants