Skip to content

🌱 Use klog.Obj in log messages#13421

Merged
k8s-ci-robot merged 3 commits intokubernetes-sigs:mainfrom
fabriziopandini:use-KObj-in-log-message
Mar 10, 2026
Merged

🌱 Use klog.Obj in log messages#13421
k8s-ci-robot merged 3 commits intokubernetes-sigs:mainfrom
fabriziopandini:use-KObj-in-log-message

Conversation

@fabriziopandini
Copy link
Copy Markdown
Member

@fabriziopandini fabriziopandini commented Mar 9, 2026

What this PR does / why we need it:
In log message we have a mix of ways for referring to objects, this PR is a first try to standardise toward usage of klog.Obj

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Rif #13305

@fabriziopandini fabriziopandini added the area/logging Issues or PRs related to logging label Mar 9, 2026
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 9, 2026
@k8s-ci-robot k8s-ci-robot requested review from chrischdi and elmiko March 9, 2026 07:22
@fabriziopandini fabriziopandini mentioned this pull request Mar 9, 2026
31 tasks
@fabriziopandini fabriziopandini changed the title Use klog.Obj in log messages 🌱 Use klog.Obj in log messages Mar 9, 2026
Comment thread controlplane/kubeadm/internal/controllers/controller.go Outdated
@fabriziopandini fabriziopandini added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 9, 2026
@sbueringer
Copy link
Copy Markdown
Member

/test pull-cluster-api-e2e-main-gke

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 9, 2026
@fabriziopandini fabriziopandini force-pushed the use-KObj-in-log-message branch from 7838184 to 5ec6738 Compare March 9, 2026 14:28
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 9, 2026
@fabriziopandini
Copy link
Copy Markdown
Member Author

/test pull-cluster-api-e2e-main-gke

@sbueringer
Copy link
Copy Markdown
Member

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: a9993f70d590f9d71ab18ce4e86d07f9546e843a

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2026
@fabriziopandini fabriziopandini force-pushed the use-KObj-in-log-message branch from 5ec6738 to 8fa98e0 Compare March 10, 2026 09:43
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2026
@k8s-ci-robot k8s-ci-robot requested a review from sbueringer March 10, 2026 09:43
@sbueringer
Copy link
Copy Markdown
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: fa14043ebf1b0ea9b24627b54fe1bbbaaf2797d4

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 852e504 into kubernetes-sigs:main Mar 10, 2026
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Mar 10, 2026
@fabriziopandini fabriziopandini deleted the use-KObj-in-log-message branch April 10, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/logging Issues or PRs related to logging cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants