🌱 certwatcher: add instance-specific logger with cert/key context

[s-z-z]

After manually updating a certificate, it’s unclear whether the target certificate was updated. This PR adds identification of the source certificate.

[k8s-ci-robot]

Hi @s-z-z. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sbueringer]

Just curious. In which case was it necessary for you to distinguish which cert was "updated" at which time?

[s-z-z]

Hi, @sbueringer
I appreciate your curiosity about the changes in the PR.
My controller includes a total of three certWatchers, including metricCertWatcher.
After updating the certificate from the certificate issuer using a tool, I cannot tell from the logs whether the certificate I operated on was updated, because the logs for all certificate updates are the same.

[sbueringer]

Let's create a logger for CertWatcher in ~ l.68 and then use that one everywhere instead

	cw := &CertWatcher{
		certPath: certPath,
		keyPath:  keyPath,
		interval: defaultWatchInterval,
		log:      log.WithValues("cert", certPath, "key", keyPath),
	}

[s-z-z]

Good idea, this simplifies similar changes in the future. As you suggested, I've updated the code.

[sbueringer]

Thx!

/ok-to-test

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Details

Git tree hash: d7a33b570bb5ab309b0e382e530900507ecf58cd

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: s-z-z, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment