📖Remove latest from setupenvtest docs#3359
Conversation
k8s-ci-robot
added
do-not-merge/invalid-commit-message
k8s-ci-robot
added
the
size/XS
troy0820
changed the title
|
|
||
| ```shell | ||
| go install sigs.k8s.io/controller-runtime/tools/setup-envtest@latest | ||
| go install sigs.k8s.io/controller-runtime/tools/setup-envtest@release-0.22 |
There was a problem hiding this comment.
Maybe it would be better to instead tell ppl to download it from a github release to avoid keeping this up to date? We will most likely forget to do that
There was a problem hiding this comment.
Let's point to the GitHub release first and then mention this with release-major.minor or some other placeholder
Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
troy0820
force-pushed
the
troy0820/update-setup-envtest-doc
branch
from
e5b6e56 to
e132b97
Compare
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
|
/lgtm I'm fine with mentioning a release branch. I would see this only as an example that we don't have to keep up to date |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. DetailsGit tree hash: 4b0c3f2b4caeb362683d4aa5ab77b4fb72e916f6 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, troy0820 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
4 participants
Instead of saying use
latestwhich can have a different go version in the go.mod at the time of reading the doc, we can just use the last release.If people want to install at latest, they will do so at their own will.
Fixes #3358
/assign @sbueringer
/assign @alvaroaleman
Not sure if this is sufficient but it does document this a little better than before.