✨ Add FieldOwner field to client.Options

[aerfio]

Introduce FieldOwner field to client.Options, to allow users to set it once, without doing it like that:

cl, err := client.New(restCfg, client.Options{})
if err != nil {
  panic(err)
}
cl = client.WithFieldOwner(cl, "field-owner")

The main reason however is the ability to set it in manager creation, so that the client we get from it using mgr.GetClient() is already correctly configured. Otherwise I have to plumb the client manually or use following code:

mgr, err := ctrl.NewManager(restCfg, ctrl.Options{
        ...
		NewClient: func(config *rest.Config, options client.Options) (client.Client, error) {
			cli, err := client.New(config, options)
			if err != nil {
				return nil, err
			}
			return client.WithFieldOwner(cli, "test-owner"), nil
		},
        ...

But the documentation of NewClient states that it's a low level primitive and should not be used unless you know what you're doing, so I'd rather not overwrite default client creation fn

[k8s-ci-robot]

Hi @aerfio. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[troy0820]

/ok-to-test

[alvaroaleman]

seems okay to me. @sbueringer WDYT? Odds are we will end up adding most/all of the wrappers in here.

/hold

[k8s-ci-robot]

LGTM label has been added.

Details

Git tree hash: 439b4f17408bf1e5554a84542279b4d791b14840

[aerfio]

@alvaroaleman My plan is to actually create the same PR but for the FieldValidation. I can also prepare other ones for any other field you've got in mind, but right now I can only see 2 With.* functions in client package

[sbueringer]

seems okay to me. @sbueringer WDYT? Odds are we will end up adding most/all of the wrappers in here.

/hold

All good from my side, just a minor point on the godoc: #3389 (comment)

[sbueringer]

Thank you very much!

/lgtm
/approve
/hold cancel

[k8s-ci-robot]

LGTM label has been added.

Details

Git tree hash: 2007aae2b26d584377139437f6e8769c40a0a2f2

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aerfio, alvaroaleman, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [alvaroaleman,sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment