Skip to content

🐛 Ensure DefaulterRemoveUnknownOrOmitableFields is still working even if objects are equal#3468

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
sbueringer:pr-fix-defaulter
Mar 5, 2026
Merged

🐛 Ensure DefaulterRemoveUnknownOrOmitableFields is still working even if objects are equal#3468
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
sbueringer:pr-fix-defaulter

Conversation

@sbueringer
Copy link
Member

@sbueringer sbueringer commented Mar 5, 2026

Signed-off-by: Stefan Büringer buringerst@vmware.com

Found this issue after bumping Cluster API to CR v0.23.2.

We have a unit test there that tests evolution of APIs and webhook configs

Follow-up fix to #3463

objects are equal

Signed-off-by: Stefan Büringer buringerst@vmware.com
@k8s-ci-robot k8s-ci-robot requested review from inteon and troy0820 March 5, 2026 13:47
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 5, 2026
@sbueringer
Copy link
Member Author

/cherry-pick release-0.23

@k8s-infra-cherrypick-robot

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-0.23 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-0.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2026
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: 930307888a21ddca9b371eb034637de917842502

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [alvaroaleman,sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 105baa6 into kubernetes-sigs:main Mar 5, 2026
19 checks passed
@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #3469

Details

In response to this:

/cherry-pick release-0.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants