Add host network portforward test.#289
Merged
feiskyer merged 1 commit intokubernetes-sigs:masterfrom Apr 18, 2018
Merged
Conversation
k8s-ci-robot
added
size/L
feiskyer
reviewed
Apr 17, 2018
pkg/validate/networking.go
Outdated
| hostNetNginxImage string = "gcr.io/cri-tools/hostnet-nginx" | ||
| nginxContainerPort int32 = 80 | ||
| // The following host ports must not be in-use when running the test. | ||
| nginxHostPortForPortMapping int32 = 8000 |
Member
There was a problem hiding this comment.
8000 is usually used for local services. Replace those ports above 10000?
Signed-off-by: Lantao Liu <lantaol@google.com>
Random-Liu
force-pushed
the
add-hostnet-port-forward
branch
from
47d1a05 to
a64b31f
Compare
Contributor
Author
|
@feiskyer Are you OK with this? :) |
k8s-ci-robot
added
the
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently found a bug that after getting rid of
nsenter, containerd doesn't support portforward for hostnetwork pod. containerd/cri#738This should be tested in CRI validation test. But this test should not be
Conformance, because it requires host network.Signed-off-by: Lantao Liu lantaol@google.com