✨ feat(alpha/update): add git commands to GH issue description#5466
✨ feat(alpha/update): add git commands to GH issue description#5466vitorfloriano wants to merge 1 commit intokubernetes-sigs:masterfrom
Conversation
The issue created by alpha update now contains git commands to facilitate checking out the branch generated by the alpha update command when there are conflicts.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vitorfloriano The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@vitorfloriano: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| - Run tests | ||
| - Confirm everything still works | ||
|
|
||
| :book: **More info:** https://kubebuilder.io/reference/commands/alpha_update |
There was a problem hiding this comment.
We need to share something like If you want to run this update manually then use alpha update.
WDYT?
There was a problem hiding this comment.
If the workflow has already created the updated branch, is it still necessary to run alpha update locally?
Then we would also need to inform users that they need to install the latest binary to do that...
I was also thinking about adding a link to the workflow that created the issue, so users can inspect the logs and understand what happened.
It could be something like this:
Description
Upgrade your project to use the latest scaffold changes introduced in Kubebuilder %[1]s.
See the release notes from %[3]s to %[1]s for details about the changes included in this upgrade.
What to do
A scheduled workflow already attempted this upgrade and created the branch (%[4]s) to help you in this process. You can see the logs from the workflow run in here: %[6]s 👈 ADD THIS
Create a Pull Request using the URL below to review the changes and resolve conflicts manually: 👈 REMOVE THIS
%[2]s
Next steps
- Fetch the %[4]s branch locally:
git fetch https://github.com/%[5]s %[4]s:%[4]s
git checkout %[4]s-
Locate and resolve the merge conflicts.
-
After fixing conflicts, run:
make manifests generate fmt vet lint-fix- Verify the changes:
- Build the project
- Run tests
- Confirm everything still works
Optional
If you wish to run this migration locally, please refer to the docs: 👈 ADD THIS TOO
📖 https://kubebuilder.io/reference/commands/alpha_update
WDYT?
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The issue created by
alpha updatenow contains git commands to facilitate checking out the branch generated by thealpha updatecommand when there are merge conflicts.