JSONToYAML wrong yaml quotation of a string with ' #' sequence

[nbykov0]

The function puts too many quotes in the yaml output if such a sequence appears in a quoted json string.

I've used such a code block to reproduce the issue:

package main
import (
	"fmt"
	"sigs.k8s.io/yaml"
)

func main() {
	j := []byte(`{"example": "OMG my ' #' is messed"}`)
	y, _ := yaml.JSONToYAML(j)
	fmt.Println(string(y))
}

Output:
example: 'OMG my '' #'' is messed'

Example of a correct behaviour:

j := []byte(`{"example": "OMG my 'a#' is messed"}`)

Output:
example: OMG my 'a#' is messed

Reproduces even if the quoted string contains any other chars around the ' #' sequence.
I can also see the bug in kubectl output and during helm rendering.

[liggitt]

Are you sure this is incorrect? '' is a correct way to escape ' inside a '-quoted string in yaml

When I put your example "incorrect" output into a parser I get back the original JSON string as expected

[nbykov0]

What about the second case where I only replace a space with a character?

I have a similar string in a configmap, and face the issue while viewing it with kubectl get -o yaml, and while templating such a string with helm.

[liggitt]

I guess the underlying library chooses different quoting styles based on whether there are internal spaces in between ' characters? yaml has many many quoting styles, it wouldn't surprise me if it varied which one was used based on the content … that doesn't necessarily mean the result is incorrect

[nbykov0]

I agree.
So seems that the issue is not the conversion style itself, but more that converting a YAML to a JSON and back to YAML will return a string different from the original one.

[liggitt]

That's certainly possible. Yaml has many different ways to express the same data, it would surprise me if roundtripping chose a different (but still valid) serialized representation of the same data.