chore: re-enable printf go vet#8743
Open
jackfrancis wants to merge 3 commits intokubernetes:masterfrom
Open
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
cncf-cla: yes
jackfrancis
force-pushed
the
go-vet-printf
branch
from
ea230d9 to
d8943f5
Compare
x13n
reviewed
Dec 5, 2025
cluster-autoscaler/Makefile
Outdated
| # Default analyzers that go test runs according to https://github.com/golang/go/blob/52624e533fe52329da5ba6ebb9c37712048168e0/src/cmd/go/internal/test/test.go#L649 | ||
| # This doesn't include the `printf` analyzer until cluster-autoscaler libraries are updated. | ||
| GO_TEST_DEFAULT_ANALYZERS?=atomic,bool,buildtags,directive,errorsas,ifaceassert,nilfunc,slog,stringintconv,tests | ||
| GO_TEST_DEFAULT_ANALYZERS?=atomic,bool,buildtags,directive,errorsas,ifaceassert,nilfunc,slog,stringintconv,tests,printf |
Member
There was a problem hiding this comment.
Could we not have an explicit list at all? If new analyzers will be added in future versions of Go, we won't run them.
k8s-ci-robot
added
the
needs-rebase
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
jackfrancis
force-pushed
the
go-vet-printf
branch
from
d8943f5 to
2a963a2
Compare
k8s-ci-robot
removed
the
needs-rebase
jackfrancis
force-pushed
the
go-vet-printf
branch
from
2a963a2 to
d1ea514
Compare
k8s-ci-robot
added
size/S
Signed-off-by: Jack Francis <jackfrancis@gmail.com>
k8s-ci-robot
added
size/M
jackfrancis
commented
Mar 11, 2026
| # Default analyzers that go test runs according to https://github.com/golang/go/blob/52624e533fe52329da5ba6ebb9c37712048168e0/src/cmd/go/internal/test/test.go#L649 | ||
| # This doesn't include the `printf` analyzer until cluster-autoscaler libraries are updated. | ||
| GO_TEST_DEFAULT_ANALYZERS?=atomic,bool,buildtags,directive,errorsas,ifaceassert,nilfunc,slog,stringintconv,tests | ||
| GO_VET_ANALYZER_NAME_FLAGS?=-appends=false -asmdecl=false -assign=false -cgocall=false -composites=false -copylocks=false -defers=false -framepointer=false -hostport=false -httpresponse=false -loopclosure=false -lostcancel=false -shift=false -sigchanyzer=false -stdmethods=false -stdversion=false -structtag=false -testinggoroutine=false -timeformat=false -unmarshal=false -unreachable=false -unsafeptr=false -unusedresult=false -waitgroup=false |
Contributor
Author
There was a problem hiding this comment.
@x13n getting back to this PR after it went stale :)
This seems to be the way to exclude go vet analyzers. Wdyt?
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jackfrancis
force-pushed
the
go-vet-printf
branch
from
33b454e to
71eddf2
Compare
Signed-off-by: Jack Francis <jackfrancis@gmail.com>
jackfrancis
force-pushed
the
go-vet-printf
branch
from
71eddf2 to
d54d3e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind failing-test
What this PR does / why we need it:
This PR re-introduces the printf go vet analyzer. In order to do that, updates are made to the various offending files, and a change to the
go testmake target is made to skip manually vendored provider SDK code.Which issue(s) this PR fixes:
Fixes #8127
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: