examples: fix linter warning#406
Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom Jun 10, 2024
Merged
Conversation
The newer golangci-lint enables a revive check by default:
output_test/output_test.go:115:42: unused-parameter: parameter 'vmodule' seems to be unused, consider removing or renaming it as _ (revive)
newLogger := func(out io.Writer, v int, vmodule string) logr.Logger {
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
This issue is currently awaiting triage. If klog contributors determine this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/XS
Author
|
/assign @harshanarayana |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshanarayana, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
MrAlias
referenced
this pull request
in open-telemetry/opentelemetry-go-contrib
Jun 17, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [k8s.io/klog/v2](https://togithub.com/kubernetes/klog) | `v2.120.1` -> `v2.130.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>kubernetes/klog (k8s.io/klog/v2)</summary> ### [`v2.130.0`](https://togithub.com/kubernetes/klog/releases/tag/v2.130.0): Prepare klog release for Kubernetes v1.31 (Take 1) [Compare Source](https://togithub.com/kubernetes/klog/compare/v2.120.1...v2.130.0) #### What's Changed - chore(\*): fix spelling of Intel Corporation by [@​jsoref](https://togithub.com/jsoref) in [https://github.com/kubernetes/klog/pull/399](https://togithub.com/kubernetes/klog/pull/399) - build: fix some linter warnings by [@​pohly](https://togithub.com/pohly) in [https://github.com/kubernetes/klog/pull/402](https://togithub.com/kubernetes/klog/pull/402) - examples: fix linter warning by [@​pohly](https://togithub.com/pohly) in [https://github.com/kubernetes/klog/pull/406](https://togithub.com/kubernetes/klog/pull/406) - Do not acquire lock for file.Sync() fsync call by [@​1978629634](https://togithub.com/1978629634) in [https://github.com/kubernetes/klog/pull/404](https://togithub.com/kubernetes/klog/pull/404) - ktesting: tone down warning about leaked test goroutine by [@​pohly](https://togithub.com/pohly) in [https://github.com/kubernetes/klog/pull/401](https://togithub.com/kubernetes/klog/pull/401) #### New Contributors - [@​jsoref](https://togithub.com/jsoref) made their first contribution in [https://github.com/kubernetes/klog/pull/399](https://togithub.com/kubernetes/klog/pull/399) - [@​1978629634](https://togithub.com/1978629634) made their first contribution in [https://github.com/kubernetes/klog/pull/404](https://togithub.com/kubernetes/klog/pull/404) **Full Changelog**: kubernetes/klog@v2.120.1...v2.130.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-go-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQxMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJTa2lwIENoYW5nZWxvZyIsImRlcGVuZGVuY2llcyJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
codeboten
referenced
this pull request
in open-telemetry/opentelemetry-collector-contrib
Jun 19, 2024
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [k8s.io/klog/v2](https://togithub.com/kubernetes/klog) | `v2.120.1` -> `v2.130.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>kubernetes/klog (k8s.io/klog/v2)</summary> ### [`v2.130.0`](https://togithub.com/kubernetes/klog/releases/tag/v2.130.0): Prepare klog release for Kubernetes v1.31 (Take 1) [Compare Source](https://togithub.com/kubernetes/klog/compare/v2.120.1...v2.130.0) #### What's Changed - chore(\*): fix spelling of Intel Corporation by [@​jsoref](https://togithub.com/jsoref) in [https://github.com/kubernetes/klog/pull/399](https://togithub.com/kubernetes/klog/pull/399) - build: fix some linter warnings by [@​pohly](https://togithub.com/pohly) in [https://github.com/kubernetes/klog/pull/402](https://togithub.com/kubernetes/klog/pull/402) - examples: fix linter warning by [@​pohly](https://togithub.com/pohly) in [https://github.com/kubernetes/klog/pull/406](https://togithub.com/kubernetes/klog/pull/406) - Do not acquire lock for file.Sync() fsync call by [@​1978629634](https://togithub.com/1978629634) in [https://github.com/kubernetes/klog/pull/404](https://togithub.com/kubernetes/klog/pull/404) - ktesting: tone down warning about leaked test goroutine by [@​pohly](https://togithub.com/pohly) in [https://github.com/kubernetes/klog/pull/401](https://togithub.com/kubernetes/klog/pull/401) #### New Contributors - [@​jsoref](https://togithub.com/jsoref) made their first contribution in [https://github.com/kubernetes/klog/pull/399](https://togithub.com/kubernetes/klog/pull/399) - [@​1978629634](https://togithub.com/1978629634) made their first contribution in [https://github.com/kubernetes/klog/pull/404](https://togithub.com/kubernetes/klog/pull/404) **Full Changelog**: kubernetes/klog@v2.120.1...v2.130.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQxMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The newer golangci-lint enables a revive check by default:
Release note: