Skip to content

Add validation to help users move from experimentClusterSigningDuration#16062

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
justinsb:validate_kube_controller_manager
Oct 25, 2023
Merged

Add validation to help users move from experimentClusterSigningDuration#16062
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
justinsb:validate_kube_controller_manager

Conversation

@justinsb
Copy link
Copy Markdown
Member

@justinsb justinsb commented Oct 25, 2023

We aren't aiming to do this in general, but if we can easily help
users find the new option for deprecated flags, that will save
everyone time.

Closes #15909

We aren't aiming to do this in general, but if we can easily help
users find the new option for deprecated flags, that will save
everyone time.

Issue kubernetes#15909
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 25, 2023
@k8s-ci-robot k8s-ci-robot requested review from hakman and zetaab October 25, 2023 13:42
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2023
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2023
@hakman
Copy link
Copy Markdown
Member

hakman commented Oct 25, 2023

/test all

@k8s-ci-robot k8s-ci-robot merged commit b93b3f3 into kubernetes:master Oct 25, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kube controller manager flag --experimental-cluster-signing-duration is removed in Kubernetes 1.25+

3 participants